On 07/11/2024 11:45, MD Danish Anwar wrote: > Add clocks, assigned-clocks and assigned-clock-parents for ICSSG Why? We see what you are doing from the diff, no point to repeat it. I don't understand why you are doing it. > > Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx> > --- > .../devicetree/bindings/soc/ti/ti,pruss.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > index 3cb1471cc6b6..cf4c5884d8be 100644 > --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > @@ -92,6 +92,17 @@ properties: > description: | > This property is as per sci-pm-domain.txt. > > + clocks: > + items: > + - description: ICSSG_CORE Clock > + - description: ICSSG_ICLK Clock > + > + assigned-clocks: > + maxItems: 1 > + > + assigned-clock-parents: > + maxItems: 1 Why? This is really not needed, so you need to explain why you are doing things differently than entire Linux kernel / DT bindings. Best regards, Krzysztof