On 07/11/24 5:01 pm, Krzysztof Kozlowski wrote: > On 07/11/2024 11:45, MD Danish Anwar wrote: >> Add clocks, assigned-clocks and assigned-clock-parents for ICSSG > > Why? We see what you are doing from the diff, no point to repeat it. I > don't understand why you are doing it. > >> >> Signed-off-by: MD Danish Anwar <danishanwar@xxxxxx> >> --- >> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >> index 3cb1471cc6b6..cf4c5884d8be 100644 >> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >> @@ -92,6 +92,17 @@ properties: >> description: | >> This property is as per sci-pm-domain.txt. >> >> + clocks: >> + items: >> + - description: ICSSG_CORE Clock >> + - description: ICSSG_ICLK Clock >> + >> + assigned-clocks: >> + maxItems: 1 >> + >> + assigned-clock-parents: >> + maxItems: 1 > > Why? This is really not needed, so you need to explain why you are doing > things differently than entire Linux kernel / DT bindings. > I need to add this to the device tree node + clocks = <&k3_clks 81 0>, /* icssg0_core_clk */ + <&k3_clks 81 20>; /* icssg0_iclk */ + assigned-clocks = <&k3_clks 81 0>; + assigned-clock-parents = <&k3_clks 81 2>; But without the above change in the binding I am getting below errors while running dtbs check. /workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@30000000: 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: '^(pru|rtu|txpru)@[0-9a-f]+$', '^pa-stats@[a-f0-9]+$', 'cfg@[a-f0-9]+$', 'iep@[a-f0-9]+$', 'interrupt-controller@[a-f0-9]+$', 'mdio@[a-f0-9]+$', 'memories@[a-f0-9]+$', 'mii-g-rt@[a-f0-9]+$', 'mii-rt@[a-f0-9]+$', 'pinctrl-[0-9]+' +/workdir/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtb: icssg@30080000: 'anyOf' conditional failed, one must be fixed: To fix this warning I added these in the binding and the warnings were fixed. > Best regards, > Krzysztof > -- Thanks and Regards, Danish
