On Mon, Nov 04, 2024 at 10:22:05AM +0200, Ciprian Marian Costea wrote: > On 11/1/2024 7:57 PM, Frank Li wrote: > > On Fri, Nov 01, 2024 at 11:29:24AM +0200, Ciprian Marian Costea wrote: > > > On 10/31/2024 6:39 PM, Frank Li wrote: > > > > > > Hello Frank, > > > > > > Thank you for your review! > > > > > > > On Thu, Oct 31, 2024 at 10:35:54AM +0200, Ciprian Costea wrote: > > > > > From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx> > > > > > > > > > > This patch adds the dt-bindings for NXP S32G2/S32G3 SoCs RTC driver. > > > > > > > > > > Co-developed-by: Bogdan-Gabriel Roman <bogdan-gabriel.roman@xxxxxxx> > > > > > Signed-off-by: Bogdan-Gabriel Roman <bogdan-gabriel.roman@xxxxxxx> > > > > > Co-developed-by: Ghennadi Procopciuc <ghennadi.procopciuc@xxxxxxx> > > > > > Signed-off-by: Ghennadi Procopciuc <ghennadi.procopciuc@xxxxxxx> > > > > > Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx> > > > > > --- > > > > > > > > next time you can cc imx@xxxxxxxxxxxxxxx > > > > > > Thanks for your suggestion, I will start adding this list. > > > > > > > > > > > > .../devicetree/bindings/rtc/nxp,s32g-rtc.yaml | 99 +++++++++++++++++++ > > > > > 1 file changed, 99 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/rtc/nxp,s32g-rtc.yaml > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,s32g-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,s32g-rtc.yaml > > > > > new file mode 100644 > > > > > index 000000000000..3694af883dc7 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,s32g-rtc.yaml > > > > > @@ -0,0 +1,99 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/rtc/nxp,s32g-rtc.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: NXP S32G2/S32G3 Real Time Clock (RTC) > > > > > + > > > > > +maintainers: > > > > > + - Bogdan Hamciuc <bogdan.hamciuc@xxxxxxx> > > > > > + - Ciprian Marian Costea <ciprianmarian.costea@xxxxxxx> > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + oneOf: > > > > > + - enum: > > > > > + - nxp,s32g2-rtc > > > > > + - items: > > > > > + - const: nxp,s32g3-rtc > > > > > + - const: nxp,s32g2-rtc > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + interrupts: > > > > > + maxItems: 1 > > > > > + > > > > > + "#clock-cells": > > > > > + const: 1 > > > > > > > > Does your RTC is clock provider? why need #clock-cells > > > > > > > > > > RTC clocking on S32G2/S32G3 has a clock mux for selecting between up to 4 > > > different clock sources (parents). > > > Now, as suggested in previous reviews, I've switched to using the CCF in > > > order to implement this hardware particularity. In the end I've resorted to > > > implementing 'assigned-*' approach which while not mandatory as per proposed > > > bindings I find it quite scalable in selecting clock sources for the RTC > > > module compared to the first iteration (V1) of this patchset. > > > > Any link of previous review? > > > > Frank > > > > Please consider the following related reviews: > > [1] https://lore.kernel.org/all/202409121403232ab1295b@mail.local/ > [2] > https://lore.kernel.org/all/6659aa90-53c5-4a91-a9f9-01120c88f107@xxxxxxxxxxx/ > [3] https://lore.kernel.org/all/20241016160823c22ccb22@mail.local/ I've replied on the prior version. Rob
