Hi, On Fri, Nov 01, 2024 at 07:22:28PM +0000, Mark Brown wrote: > On Fri, Nov 01, 2024 at 08:04:52PM +0100, Sebastian Reichel wrote: > > On Fri, Nov 01, 2024 at 10:41:14PM +0800, Chen-Yu Tsai wrote: > > > > There's still the issue of backwards compatibility with older device > > > trees that are missing said supply though. > > > Exactly :) > > > As far as I can see the same misuse potential also exists for the > > plain devm_regulator_get() version. > > You'll get warnings but I'm not sure that's such a huge issue? I see that as a feature and not as an issue. Obviously the dependency should be properly described in DT. When we upstreamed GPU support for RK3588 we did not mark the GPU regulator as always-on [*] and that has been copied to all other upstreamed RK3588 board DTs. This means all of them are buggy now. Getting a warning might help people to understand what is going on. In any case I fixed up every in-tree user as part of this series. [*] Older Rockchip platforms (which are not touched by this series) and downstream RK3588 have the GPU regulator marked as always-on. Greetings, -- Sebastian
Attachment:
signature.asc
Description: PGP signature
