On 28/10/2024 08:16, Inochi Amaoto wrote: > On Mon, Oct 28, 2024 at 08:06:25AM +0100, Krzysztof Kozlowski wrote: >> On 28/10/2024 00:32, Inochi Amaoto wrote: >>> On Sun, Oct 27, 2024 at 09:38:00PM +0100, Krzysztof Kozlowski wrote: >>>> On Fri, Oct 25, 2024 at 09:09:58AM +0800, Inochi Amaoto wrote: >>>>> The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC >>>>> with some extra clock. >>>>> >>>>> Add necessary compatible string for this device. >>>>> >>>>> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx> >>>>> --- >>>> >>>> This should be squashed with a corrected previous patch >>> >>> Good, I will. >>> >>>> (why do you need to select snps,dwmac-5.30a?), >>> >>> The is because the driver use the fallback versioned compatible >>> string to set up some common arguments. (This is what the patch >> >> Nope. Driver never relies on schema doing select. That's just incorrect. >> > > Yeah, I make a mistake on understanding you. For me, I just followed > what others do. But there is a comment before this select. > > """ > Select every compatible, including the deprecated ones. This way, we > will be able to report a warning when we have that compatible, since > we will validate the node thanks to the select, but won't report it > as a valid value in the compatible property description > """ > > By reading this, I think there may be some historical reason? Maybe > someone can explain this. I think this is left-over from older times before all specific compatibles were added here and in their bindings. This binding has been waiting for some cleanup for a while now, so this is fine. I still think the patches should be merged, though. Best regards, Krzysztof
