On 28/10/2024 00:32, Inochi Amaoto wrote: > On Sun, Oct 27, 2024 at 09:38:00PM +0100, Krzysztof Kozlowski wrote: >> On Fri, Oct 25, 2024 at 09:09:58AM +0800, Inochi Amaoto wrote: >>> The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC >>> with some extra clock. >>> >>> Add necessary compatible string for this device. >>> >>> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx> >>> --- >> >> This should be squashed with a corrected previous patch > > Good, I will. > >> (why do you need to select snps,dwmac-5.30a?), > > The is because the driver use the fallback versioned compatible > string to set up some common arguments. (This is what the patch Nope. Driver never relies on schema doing select. That's just incorrect. > 3 does). It is also better to have a accurate fallback compatible > if we already know what it is. Best regards, Krzysztof
