On Mon, Oct 28, 2024 at 4:54 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Fri, Oct 25, 2024 at 06:44:41PM +0800, Fei Shao wrote: > > Add "mediatek,adsp" property for the ADSP handle if ADSP is enabled on > > the platform. > > We see this from the diff. > > > Add "mediatek,dai-link" property for the required DAI links to configure > > sound card. > > We see this from the diff. > > > > > Both properties are commonly used in the MediaTek sound card driver. > > If they are used, why suddenly they are needed? What changed? Nothing has changed. These should have been added altogether when the binding was first introduced. This patch is to fill the gaps and fix dtbs_check warnings, like I mentioned in the cover letter. I can add a line in the commit message saying it's to fix the warning in addition to the cover letter, if that's preferred. > > > > > Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx> > > --- > > > > .../bindings/sound/mediatek,mt8188-mt6359.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > > index f94ad0715e32..701cedfa38d2 100644 > > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > > @@ -29,6 +29,16 @@ properties: > > $ref: /schemas/types.yaml#/definitions/phandle > > description: The phandle of MT8188 ASoC platform. > > > > + mediatek,adsp: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of MT8188 ADSP platform. > > And what is the difference between ASoC and ADSP platforms? What are > they used for? I'm not a MediaTek or audio folks, and I'm afraid that I'm not the best person to explain the details accurately in front of experts on the list... I know it's an audio DSP but that explains nothing. MediaTek didn't provide a meaningful explanation in the tree or commits, and I want to avoid adding additional but likely misleading descriptions from someone who doesn't have enough knowledge, potentially causing even more confusing situations in the future. Plus, the same changes were accepted as-is in the past, so I assumed they might be self-explanatory to people who are familiar with the matter. > > > + > > + mediatek,dai-link: > > + $ref: /schemas/types.yaml#/definitions/string-array > > + description: > > + A list of the desired dai-links in the sound card. Each entry is a > > + name defined in the machine driver. > > The list is provided below. I don't understand why do you need it. Your > msg is pretty useless - you describe what you do, instead of why. I think this is used to explicitly list the intermediate but hidden DAIs, but again, there's not much info about them unless MediaTek can explain more details and why they need a vendor property for this. Regards, Fei > > Best regards, > Krzysztof >
