On Mon, Oct 28, 2024 at 4:52 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Fri, Oct 25, 2024 at 06:42:45PM +0800, Fei Shao wrote: > > The MediaTek DP hardware supports audio, and the "#sound-dai-cells" > > property is required to describe DAI links and audio routing. > > > > Add "#sound-dai-cells" property to the binding and filter out non-DP > > compatibles, as MediaTek eDP doesn't support audio. > > > > Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx> > > --- > > > > .../bindings/display/mediatek/mediatek,dp.yaml | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > index 2aef1eb32e11..c05c2b409780 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml > > @@ -42,6 +42,9 @@ properties: > > interrupts: > > maxItems: 1 > > > > + "#sound-dai-cells": > > + const: 0 > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > properties: > > @@ -87,6 +90,19 @@ required: > > > > You need to reference dai-common instead, since this is DAI. I'll add that. And if I understand your feedback in another patch correctly, I assume I need to reference dai-common and also keep the original #sound-dai-cells lines for the number of DAIs, so I'll keep that. Please correct me if I'm wrong. > > > additionalProperties: false > > and this becomes unevaluatedProperties: false Acknowledged. Regards, Fei > > Best regards, > Krzysztof >
