On Fri, Oct 25, 2024 at 06:44:41PM +0800, Fei Shao wrote: > Add "mediatek,adsp" property for the ADSP handle if ADSP is enabled on > the platform. We see this from the diff. > Add "mediatek,dai-link" property for the required DAI links to configure > sound card. We see this from the diff. > > Both properties are commonly used in the MediaTek sound card driver. If they are used, why suddenly they are needed? What changed? > > Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx> > --- > > .../bindings/sound/mediatek,mt8188-mt6359.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > index f94ad0715e32..701cedfa38d2 100644 > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > @@ -29,6 +29,16 @@ properties: > $ref: /schemas/types.yaml#/definitions/phandle > description: The phandle of MT8188 ASoC platform. > > + mediatek,adsp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT8188 ADSP platform. And what is the difference between ASoC and ADSP platforms? What are they used for? > + > + mediatek,dai-link: > + $ref: /schemas/types.yaml#/definitions/string-array > + description: > + A list of the desired dai-links in the sound card. Each entry is a > + name defined in the machine driver. The list is provided below. I don't understand why do you need it. Your msg is pretty useless - you describe what you do, instead of why. Best regards, Krzysztof
