> Hello Daniel, > > On Mon, 21 Oct 2024 15:58:42 +0200 > Daniel Machon <daniel.machon@xxxxxxxxxxxxx> wrote: > > > Lan969x will require a few additional registers for certain operations. > > Some are shared, some are not. Add these. > > > > Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx> > > Signed-off-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx> > > [...] > > > +#define PTP_PTP_TWOSTEP_STAMP_SUBNS_STAMP_SUB_NSEC GENMASK(7, 0) > > I understand that this is partly autogenerated, however the naming for > this register in particular seems very redundant... Is there any way > this could be improved ? > > Thanks, > > Maxime > Yes, this might be a new candidate for "the longest name in the kernel" award. This particular register is a concatenation of: PTP (target) PTP_TS_FIFO (register group) PTP_TWOSTEP_STAMP_SUBNS (register) STAMP_SUB_NSEC (field), and as you can see the register group part is already removed. That said, the tool for generating this, can be tweaked to rename registers if required - I will do that here :-) Thanks! /Daniel
