Hi Maxime,
> Hi Daniel,
>
> On Mon, 21 Oct 2024 15:58:47 +0200
> Daniel Machon <daniel.machon@xxxxxxxxxxxxx> wrote:
>
> > Add PTP IRQ handler for lan969x. This is required, as the PTP registers
> > are placed in two different targets on Sparx5 and lan969x. The
> > implementation is otherwise the same as on Sparx5.
> >
> > Also, expose sparx5_get_hwtimestamp() for use by lan969x.
> >
> > Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx>
> > Signed-off-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>
>
> [...]
>
> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> > index 15f5d38776c4..3f66045c57ef 100644
> > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> > @@ -114,6 +114,8 @@ enum sparx5_vlan_port_type {
> > #define SPX5_DSM_CAL_LEN 64
> > #define SPX5_DSM_CAL_MAX_DEVS_PER_TAXI 13
> >
> > +#define SPARX5_MAX_PTP_ID 512
> > +
>
> Sorry if I somehow missed it, but if you define SPARX5_MAX_PTP_ID here,
> you probably don't need it to be also defined in sparx5_ptp.c as well ?
>
> Thanks,
>
> Maxime
You are right. It should definitely be removed from sparx5_ptp.c
Will fix it in v2. Thanks!
/Daniel
