On Wed, Oct 16, 2024 at 01:48:41AM -0400, Markus Stockhausen wrote: > Add bindings for the SerDes of the Realtek Otto platform. These are > MIPS based network Switch SoCs with up to 52 ports divided into four > different model lines. > > Changes in v4 > You still did not respond to my feedback from v2. I reminded you this at v3 and you keep ignoring it. Limited review follows because of this. > - fixed addresses in example > - missing firmware-name denotes "skip firmware" instead empty string > - fixed reg porperty > > Changes in v3 > > - renamed to realtek,rtl8380m-serdes.yaml > - removed parameter controlled-ports > - verified with make dt_binding_check > - recipient list according to get_maintainers > > Changes in v2: > > - new subject > - removed patch command sequences > - renamed parameter controlled-ports to realtek,controlled-ports > > Signed-off-by: Markus Stockhausen <markus.stockhausen@xxxxxx> > --- > .../bindings/phy/realtek,rtl8380m-serdes.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/realtek,rtl8380m-serdes.yaml > > diff --git a/Documentation/devicetree/bindings/phy/realtek,rtl8380m-serdes.yaml b/Documentation/devicetree/bindings/phy/realtek,rtl8380m-serdes.yaml > new file mode 100644 > index 000000000000..8ccb3a34b221 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/realtek,rtl8380m-serdes.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/realtek,rtl8380m-serdes.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek Otto SerDes controller > + > +maintainers: > + - Markus Stockhausen <markus.stockhausen@xxxxxx> > + > +description: > + The MIPS based Realtek Switch SoCs of the Realtek RTL838x, RTL839x, RTL930x > + and RTL931x series have multiple SerDes built in. They are linked to single, > + quad or octa PHYs like the RTL8218B, RTL8218D or RTL8214FC and are one of > + the integral part of the up-to-52-port switch architecture. Although these > + SerDes controllers have common basics they are designed differently in the > + SoC families. > + > +properties: > + $nodename: > + pattern: "^phy@[0-9a-f]+$" Drop nodename. > + > + compatible: > + items: Drop items and place here enum directly. Best regards, Krzysztof
