Hi Rob, I am so sorry that I didn't check dts, I have some questions. Rob Herring (Arm) <robh@xxxxxxxxxx> 于2024年10月15日周二 22:17写道： > > > On Tue, 15 Oct 2024 20:26:05 +0800, Zhengqiao Xia wrote: > > MT8186 chinchou, known as ASUS Chromebook CZ12 Flip, is a > > MT8186 based laptop. It is based on the "corsola" design. > > It includes chinchou and chinchou360, including LTE, stylus, > > touchscreen combinations. > > > > Zhengqiao Xia (3): > > dt-bindings: arm: mediatek: Add MT8186 Chinchou Chromebook > > arm64: dts: mediatek: Add MT8186 Chinchou Chromebooks > > arm64: dts: mediatek: Add exton node for DP bridge > > > > .../devicetree/bindings/arm/mediatek.yaml | 26 ++ > > arch/arm64/boot/dts/mediatek/Makefile | 3 + > > .../mediatek/mt8186-corsola-chinchou-sku0.dts | 18 ++ > > .../mediatek/mt8186-corsola-chinchou-sku1.dts | 34 ++ > > .../mt8186-corsola-chinchou-sku16.dts | 28 ++ > > .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 296 ++++++++++++++++++ > > .../boot/dts/mediatek/mt8186-corsola.dtsi | 6 + > > 7 files changed, 411 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi > > > > -- > > 2.17.1 > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-chinchou-sku0.dtb mediatek/mt8186-corsola-chinchou-sku1.dtb mediatek/mt8186-corsola-chinchou-sku16.dtb' for 20241015122608.24569-1-xiazhengqiao@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx: > > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed: > ['google,chinchou-sku1', 'google,chinchou-sku17', 'google,chinchou-sku3', 'google,chinchou-sku6', 'google,chinchou-sku7', 'google,chinchou-sku20', 'google,chinchou-sku22', 'google,chinchou-sku23', 'mediatek,mt8186'] is too long > 'google,chinchou-sku1' is not one of ['mediatek,mt2701-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt2712-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt6580-evbp1'] > 'google,chinchou-sku1' is not one of ['prestigio,pmt5008-3g'] > 'google,chinchou-sku1' is not one of ['fairphone,fp1', 'mundoreader,bq-aquaris5'] > 'google,chinchou-sku1' is not one of ['mediatek,mt6592-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt6755-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt6765-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt6779-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt6795-evb', 'sony,xperia-m5'] > 'google,chinchou-sku1' is not one of ['archermind,mt6797-x20-dev', 'mediatek,mt6797-evb'] > 'google,chinchou-sku1' is not one of ['bananapi,bpi-r64', 'mediatek,mt7622-rfb1'] > 'google,chinchou-sku1' is not one of ['mediatek,mt7623a-rfb-emmc', 'mediatek,mt7623a-rfb-nand', 'mediatek,mt7623n-rfb-emmc', 'bananapi,bpi-r2'] > 'google,chinchou-sku1' is not one of ['mediatek,mt7629-rfb'] > 'google,chinchou-sku1' is not one of ['cudy,wr3000-v1', 'openwrt,one', 'xiaomi,ax3000t'] > 'google,chinchou-sku1' is not one of ['acelink,ew-7886cax', 'bananapi,bpi-r3', 'bananapi,bpi-r3mini', 'mediatek,mt7986a-rfb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt7986b-rfb'] > 'google,chinchou-sku1' is not one of ['bananapi,bpi-r4'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8127-moose'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8135-evbp1'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8167-pumpkin'] > 'google,elm-rev8' was expected > 'google,hana-rev6' was expected > 'google,hana-rev7' was expected > 'google,chinchou-sku1' is not one of ['mediatek,mt8173-evb'] > 'google,burnet' was expected > 'google,cozmo' was expected > 'google,damu' was expected > 'google,chinchou-sku1' is not one of ['google,fennel-sku0', 'google,fennel-sku1', 'google,fennel-sku2', 'google,fennel-sku6', 'google,fennel-sku7'] > 'google,chinchou-sku1' is not one of ['google,juniper-sku16', 'google,juniper-sku17'] > 'google,kakadu-rev3' was expected > 'google,kakadu-rev3-sku22' was expected > 'google,kappa' was expected > 'google,chinchou-sku1' is not one of ['google,katsu-sku32', 'google,katsu-sku38'] > 'google,chinchou-sku1' is not one of ['google,kodama-sku16', 'google,kodama-sku272', 'google,kodama-sku288', 'google,kodama-sku32'] > 'google,chinchou-sku1' is not one of ['google,krane-sku0', 'google,krane-sku176'] > 'google,chinchou-sku1' is not one of ['google,makomo-sku0', 'google,makomo-sku1'] > 'google,chinchou-sku1' is not one of ['google,pico-sku1', 'google,pico-sku2'] > 'google,chinchou-sku1' is not one of ['google,willow-sku0', 'google,willow-sku1'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8183-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8183-pumpkin'] > 'google,chinchou-sku0' was expected > 'google,chinchou-sku16' was expected > 'google,steelix-sku393219' was expected > 'google,steelix-sku393220' was expected > 'google,steelix-sku393221' was expected > 'google,steelix-sku196609' was expected > 'google,chinchou-sku1' is not one of ['google,steelix-sku131072', 'google,steelix-sku131073'] > 'google,tentacruel-sku262147' was expected > 'google,tentacruel-sku262151' was expected > 'google,tentacruel-sku327681' was expected > 'google,tentacruel-sku327683' was expected > 'google,chinchou-sku1' is not one of ['google,voltorb-sku589824', 'google,voltorb-sku589825'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8186-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8188-evb'] > 'google,hayato-rev1' was expected > 'google,hayato-rev5-sku2' was expected > 'google,spherion-rev3' was expected > 'google,spherion-rev4' was expected > 'google,chinchou-sku1' is not one of ['mediatek,mt8192-evb'] > 'google,chinchou-sku1' is not one of ['google,tomato-rev2', 'google,tomato-rev1'] > 'google,tomato-rev4' was expected > 'google,dojo-sku7' was expected > 'google,chinchou-sku1' is not one of ['mediatek,mt8195-demo', 'mediatek,mt8195-evb'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8365-evk'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8390-evk'] > 'google,chinchou-sku1' is not one of ['kontron,3-5-sbc-i1200', 'mediatek,mt8395-evk', 'radxa,nio-12l'] > 'google,chinchou-sku1' is not one of ['mediatek,mt8516-pumpkin'] > 'mediatek,mt2701' was expected > 'mediatek,mt2712' was expected > 'mediatek,mt6580' was expected > 'mediatek,mt6582' was expected > 'mediatek,mt6589' was expected > 'mediatek,mt6592' was expected > 'mediatek,mt6755' was expected > 'mediatek,mt6765' was expected > 'mediatek,mt6779' was expected > 'mediatek,mt6795' was expected > 'mediatek,mt6797' was expected > 'mediatek,mt7622' was expected > 'mediatek,mt7623' was expected > 'mediatek,mt7629' was expected > 'mediatek,mt7981b' was expected > 'mediatek,mt7986a' was expected > 'mediatek,mt7986b' was expected > 'mediatek,mt7988a' was expected > 'mediatek,mt8127' was expected > 'mediatek,mt8135' was expected > 'mediatek,mt8167' was expected > 'google,elm-rev7' was expected > 'google,hana-rev5' was expected > 'mediatek,mt8173' was expected > 'mediatek,mt8183' was expected > 'google,fennel' was expected > 'google,juniper' was expected > 'google,kakadu-rev2' was expected > 'google,kakadu-rev2-sku22' was expected > 'google,katsu' was expected > 'google,kodama' was expected > 'google,krane' was expected > 'google,makomo' was expected > 'google,pico' was expected > 'google,willow' was expected > 'google,chinchou-sku2' was expected > 'google,chinchou-sku3' was expected > 'google,chinchou-sku18' was expected > 'google,steelix-sku393216' was expected > 'google,steelix-sku393217' was expected > 'google,steelix-sku393218' was expected > 'google,steelix-sku196608' was expected > 'google,steelix' was expected > 'google,tentacruel-sku262146' was expected > 'google,tentacruel-sku262150' was expected > 'google,tentacruel' was expected > 'google,voltorb' was expected > 'mediatek,mt8186' was expected > 'mediatek,mt8188' was expected > 'google,hayato' was expected > 'google,hayato-sku2' was expected > 'google,spherion-rev2' was expected > 'google,spherion' was expected > 'mediatek,mt8192' was expected > 'google,tomato' was expected > 'google,tomato-rev3' was expected > 'google,dojo-sku5' was expected > 'mediatek,mt8195' was expected > 'mediatek,mt8365' was expected > 'mediatek,mt8390' was expected > 'mediatek,mt8395' was expected > 'mediatek,mt8516' was expected > 'google,elm-rev6' was expected > 'google,hana-rev4' was expected > 'google,kakadu' was expected > 'google,chinchou-sku4' was expected > 'google,chinchou-sku6' was expected > 'google,chinchou-sku19' was expected > 'google,tentacruel-sku262145' was expected > 'google,tentacruel-sku262149' was expected > 'google,spherion-rev1' was expected > 'google,dojo-sku3' was expected > 'google,elm-rev5' was expected > 'google,hana-rev3' was expected > 'google,chinchou-sku5' was expected > 'google,chinchou-sku7' was expected > 'google,chinchou-sku21' was expected > 'google,tentacruel-sku262144' was expected > 'google,tentacruel-sku262148' was expected > 'google,spherion-rev0' was expected > 'google,dojo-sku1' was expected > 'google,elm-rev4' was expected > 'google,hana' was expected > 'google,chinchou' was expected > 'google,chinchou-sku17' was expected > 'google,dojo' was expected > 'google,elm-rev3' was expected > 'google,elm' was expected I don't know how to solve this, there are so many skus in chinchou, I can't remove that. > from schema $id: http://devicetree.org/schemas/arm/mediatek.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: pinctrl@10005000: 'pin-report' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8186-pinctrl.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: pinctrl@10005000: 'pin-report' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8186-pinctrl.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: pinctrl@10005000: 'pin-report' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8186-pinctrl.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc'] These errors are not caused by me, do I need to add them? > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: touchscreen@41: 'vcc33-supply' is a required property > from schema $id: http://devicetree.org/schemas/input/ilitek,ili2901.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: touchscreen@41: 'vcc33-supply' is a required property > from schema $id: http://devicetree.org/schemas/input/ilitek,ili2901.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: rt5650@1a: 'cpvdd-supply' is a required property > from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: rt5650@1a: Unevaluated properties are not allowed ('cbj-sleeve-gpio' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: rt5650@1a: 'cpvdd-supply' is a required property > from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: rt5650@1a: Unevaluated properties are not allowed ('cbj-sleeve-gpio' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: rt5650@1a: 'cpvdd-supply' is a required property > from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: rt5650@1a: Unevaluated properties are not allowed ('cbj-sleeve-gpio' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: sound: 'model' is a required property > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: sound: playback-codecs:sound-dai: [[183]] is too short > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: sound: Unevaluated properties are not allowed ('playback-codecs' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: sound: 'model' is a required property > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: sound: playback-codecs:sound-dai: [[183]] is too short > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: sound: Unevaluated properties are not allowed ('playback-codecs' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: sound: 'model' is a required property > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: sound: playback-codecs:sound-dai: [[181]] is too short > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: sound: Unevaluated properties are not allowed ('playback-codecs' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: regulator-pp1800-tchscr-report-disable: Unevaluated properties are not allowed ('enable-active-low' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: regulator-pp1800-tchscr-report-disable: Unevaluated properties are not allowed ('enable-active-low' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: regulator-pp1800-tchscr-report-disable: Unevaluated properties are not allowed ('enable-active-low' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml# > > > > >
