> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: 2024年10月16日 5:59 > To: Wei Fang <wei.fang@xxxxxxx> > Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; Vladimir > Oltean <vladimir.oltean@xxxxxxx>; Claudiu Manoil > <claudiu.manoil@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>; Frank Li > <frank.li@xxxxxxx>; christophe.leroy@xxxxxxxxxx; linux@xxxxxxxxxxxxxxx; > bhelgaas@xxxxxxxxxx; horms@xxxxxxxxxx; imx@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 net-next 02/13] dt-bindings: net: add i.MX95 ENETC > support > > On Tue, Oct 15, 2024 at 08:58:30PM +0800, Wei Fang wrote: > > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor > > ID and device ID have also changed, so add the new compatible strings > > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII > > or RMII reference clock. > > > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx> > > --- > > v2 changes: remove "nxp,imx95-enetc" compatible string. > > --- > > .../devicetree/bindings/net/fsl,enetc.yaml | 19 +++++++++++++++---- > > 1 file changed, 15 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > index e152c93998fe..409ac4c09f63 100644 > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > > @@ -20,14 +20,25 @@ maintainers: > > > > properties: > > compatible: > > - items: > > - - enum: > > - - pci1957,e100 > > - - const: fsl,enetc > > + oneOf: > > + - items: > > + - enum: > > + - pci1957,e100 > > + - const: fsl,enetc > > + - items: > > You can omit items here. > > > + - const: pci1131,e101 > > > > reg: > > maxItems: 1 > > > > + clocks: > > + items: > > + - description: MAC transmit/receiver reference clock > > + > > + clock-names: > > + items: > > + - const: enet_ref_clk > > Clock names are local to the block, so 'enet_' is redundant. It's all > clock names, so '_clk' is redundant too. IOW, just use 'ref'. > Okay, I'll change its name. > > + > > mdio: > > $ref: mdio.yaml > > unevaluatedProperties: false > > -- > > 2.34.1 > >
