On Tue, Oct 15, 2024 at 08:58:30PM +0800, Wei Fang wrote: > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor > ID and device ID have also changed, so add the new compatible strings > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII > or RMII reference clock. > > Signed-off-by: Wei Fang <wei.fang@xxxxxxx> > --- > v2 changes: remove "nxp,imx95-enetc" compatible string. > --- > .../devicetree/bindings/net/fsl,enetc.yaml | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > index e152c93998fe..409ac4c09f63 100644 > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml > @@ -20,14 +20,25 @@ maintainers: > > properties: > compatible: > - items: > - - enum: > - - pci1957,e100 > - - const: fsl,enetc > + oneOf: > + - items: > + - enum: > + - pci1957,e100 > + - const: fsl,enetc > + - items: You can omit items here. > + - const: pci1131,e101 > > reg: > maxItems: 1 > > + clocks: > + items: > + - description: MAC transmit/receiver reference clock > + > + clock-names: > + items: > + - const: enet_ref_clk Clock names are local to the block, so 'enet_' is redundant. It's all clock names, so '_clk' is redundant too. IOW, just use 'ref'. > + > mdio: > $ref: mdio.yaml > unevaluatedProperties: false > -- > 2.34.1 >
