On Thu, Oct 10, 2024 at 11:17:35PM +0200, Jérôme de Bretagne wrote: > Le jeu. 10 oct. 2024 à 10:52, Johan Hovold <johan@xxxxxxxxxx> a écrit : > > On Mon, Sep 09, 2024 at 12:35:05AM +0200, Jérôme de Bretagne wrote: > > You mention it in the commit message, but since a lot of this is copied > > from the X13s (and CRD) devicetrees you should probably make that clear > > here as well and include the relevant copyright notices. For example by > > adding: > > > > Based on ... > > > > Copyright ... > Thank you for the suggestion, so it would look like this? You can still keep your copyright notice first, and I meant something like: /* * Microsoft Surface Pro 9 5G devicetree * * Copyright (c) 2024, Jérôme de Bretagne <...> * * Based on sc8280xp-crd.dts and sc8280xp-lenovo-thinkpad-x13s.dts: * * Copyright (c) 2021, The Linux Foundation. All rights reserved. * Copyright (c) 2022, Linaro Limited */ > How do you want me to add this to the patchset? > Should I send a separate fix-up patch? > Or should I create a newer v3 patchset? Ah, sorry, I missed that Bjorn had already picked this one up. Either leave it as is, or send an incremental (fix-up) patch. Johan
