Le jeu. 10 oct. 2024 à 10:52, Johan Hovold <johan@xxxxxxxxxx> a écrit : > > On Mon, Sep 09, 2024 at 12:35:05AM +0200, Jérôme de Bretagne wrote: > > Add an initial devicetree for the Microsoft Surface Pro 9 5G, based > > on SC8280XP. > > > > It enables the support for Wi-Fi, NVMe, the two USB Type-C ports, > > Bluetooth, 5G cellular modem, audio output (via Bluetooth headsets > > or USB audio), external display via DisplayPort over Type-C (only > > the bottom USB Type-C port is working so far), charging, the Surface > > Aggregator Module (SAM) to get keyboard and touchpad working with > > Surface Type Cover accessories. > > > > Some key features not supported yet: > > - built-in display (but software fallback is working with efifb > > when blacklisting the msm module) > > - built-in display touchscreen > > - external display with the top USB Type-C port > > - speakers and microphones > > - physical volume up and down keys > > - LID switch detection > > > > This devicetree is based on the other SC8280XP ones, for the Lenovo > > ThinkPad X13s and the Qualcomm CRD. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Signed-off-by: Jérôme de Bretagne <jerome.debretagne@xxxxxxxxx> > > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2024, Jérôme de Bretagne <jerome.debretagne@xxxxxxxxx> > > + */ > > You mention it in the commit message, but since a lot of this is copied > from the X13s (and CRD) devicetrees you should probably make that clear > here as well and include the relevant copyright notices. For example by > adding: > > Based on ... > > Copyright ... > > Johan Thank you for the suggestion, so it would look like this? +// SPDX-License-Identifier: BSD-3-Clause +/* + * Based on sc8280xp-crd.dts and sc8280xp-lenovo-thinkpad-x13s.dts + * + * Copyright (c) 2021, The Linux Foundation. All rights reserved. + * Copyright (c) 2022, Linaro Limited + * Copyright (c) 2024, Jérôme de Bretagne <...> + */ Bjorn, How do you want me to add this to the patchset? Should I send a separate fix-up patch? Or should I create a newer v3 patchset? Thank you, Jérôme
