Re: [PATCH v2 1/6] dt-bindings: media: qcom,sc8280xp-camss: Fix interrupt types

[Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>]

Hi Bjorn,

On 10/6/24 05:36, Bjorn Andersson wrote:
> On Mon, Sep 23, 2024 at 10:28:22AM GMT, Vladimir Zapolskiy wrote:
> > The expected type of all CAMSS interrupts is edge rising, fix it in
> > the documented example from CAMSS device tree bindings for sc8280xp.
>
> Who/what expects them to be RISING?

I've checked CAMSS device tree bindings in a number of downstream kernels,
all of them describe interrupt types as edge rising.

$ grep -Hn IRQF_TRIGGER drivers/media/platform/qcom/camss/*
drivers/media/platform/qcom/camss/camss-csid.c:619:			       IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN,
drivers/media/platform/qcom/camss/camss-csiphy.c:605:			       IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN,
drivers/media/platform/qcom/camss/camss-ispif.c:1164:			       IRQF_TRIGGER_RISING, ispif->irq_name, ispif);
drivers/media/platform/qcom/camss/camss-ispif.c:1168:			       IRQF_TRIGGER_RISING, ispif->irq_name, ispif);
drivers/media/platform/qcom/camss/camss-vfe.c:1327:			       IRQF_TRIGGER_RISING, vfe->irq_name, vfe);

From runtime point of view it's more important to get re-probed camss
driver, see an absolutely similar and previously discussed case (in the
cover letter):

https://lore.kernel.org/lkml/20220530080842.37024-4-manivannan.sadhasivam@xxxxxxxxxx/

Now in runtime I get this error, it's easy to check by unbinding/binding any
camss device:

irq: type mismatch, failed to map hwirq-509 for interrupt-controller@17a00000!

Basically camss devices can not be bound on the second time on the
number of platforms touched by this changeset.

> > Fixes: bc5191e5799e ("media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding")
> > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > ---
> >   .../bindings/media/qcom,sc8280xp-camss.yaml   | 40 +++++++++----------
> >   1 file changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> > index c0bc31709873..9936f0132417 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> > @@ -328,26 +328,26 @@ examples:
> >               vdda-phy-supply = <&vreg_l6d>;
> >               vdda-pll-supply = <&vreg_l4d>;
> >   
> > -            interrupts = <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 468 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 469 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 477 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 478 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 640 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 758 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 759 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 760 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 761 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 762 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 764 IRQ_TYPE_LEVEL_HIGH>;
> > +            interrupts = <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 464 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 466 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 640 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 641 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 762 IRQ_TYPE_EDGE_RISING>,
> > +                         <GIC_SPI 764 IRQ_TYPE_EDGE_RISING>;
> >   
> >               interrupt-names = "csid1_lite",
> >                                 "vfe_lite1",
> > --
> > 2.45.2

--
Best wishes,
Vladimir