On Mon, Sep 23, 2024 at 10:28:22AM GMT, Vladimir Zapolskiy wrote:
> The expected type of all CAMSS interrupts is edge rising, fix it in
> the documented example from CAMSS device tree bindings for sc8280xp.
>
Who/what expects them to be RISING?
Regards,
Bjorn
> Fixes: bc5191e5799e ("media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding")
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../bindings/media/qcom,sc8280xp-camss.yaml | 40 +++++++++----------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> index c0bc31709873..9936f0132417 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> @@ -328,26 +328,26 @@ examples:
> vdda-phy-supply = <&vreg_l6d>;
> vdda-pll-supply = <&vreg_l4d>;
>
> - interrupts = <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 360 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 468 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 469 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 477 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 478 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 640 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 758 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 759 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 760 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 761 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 762 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 764 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 464 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 466 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 640 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 641 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 762 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 764 IRQ_TYPE_EDGE_RISING>;
>
> interrupt-names = "csid1_lite",
> "vfe_lite1",
> --
> 2.45.2
>
