Hello Marek, On 9/26/24 21:55, Marek Vasut wrote: > Do not use wilc_get_chipid() outside of wlan.c . Instead, call > wilc_get_chipid() right after the SDIO/SPI interface has been > initialized to cache the device chipid, and then use the cached > chipid throughout the driver. Make wilc_get_chipid() return a > proper return value instead of a chipid. This new update now makes the commit message wrong, wilc_get_chipid is used in files other than wlan.c (and this change goal is now rather to get the chip id early enough to register wiphy with correct info) > Signed-off-by: Marek Vasut <marex@xxxxxxx> With the point above fixed: Reviewed-by: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
