Re: [PATCH v6 2/7] wifi: wilc1000: Fold wilc_get_chipid() into wlan.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/3/24 10:04 AM, Alexis Lothoré wrote:
Hello Marek,

Hi,

On 9/26/24 21:55, Marek Vasut wrote:
Do not use wilc_get_chipid() outside of wlan.c . Instead, call
wilc_get_chipid() right after the SDIO/SPI interface has been
initialized to cache the device chipid, and then use the cached
chipid throughout the driver. Make wilc_get_chipid() return a
proper return value instead of a chipid.

This new update now makes the commit message wrong, wilc_get_chipid is used in
files other than wlan.c (and this change goal is now rather to get the chip id
early enough to register wiphy with correct info)

Signed-off-by: Marek Vasut <marex@xxxxxxx>

With the point above fixed:

Reviewed-by: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx>
Fixed in V7, thanks !




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux