On Tue, Oct 01, 2024 at 01:18:29PM +0200, Linus Walleij wrote: > On Sat, Sep 28, 2024 at 10:05 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Sat, Sep 28, 2024 at 12:29:47AM +0200, Linus Walleij wrote: > > > + brcm,serial-shift-bits: > > > > bits is an uint32-array, so you need to limit number of items, e.g. > > items: > > - minimum: 1 > > maximum: 32 > > OK this is what I do on the next lines: > > > > + minimum: 1 > > > + maximum: 32 > > Am I doing something wrong here? I see you have a dash > - minimum in your comment but when I grep through the > existing bindings for stuff ending with -bits it seems they > do what I do. All the unit suffixes started as single values, but then we found some cases with more than 1 (and even a matrix for opp-hz) and had to extend them. I think what you have here is fine. We can imply it's 1 entry given the scalar constraints. > > > default: [0]? or something else? > > Since we need to stay compatible with older device trees > the default is whatever is in the hardware after boot :/ > > I guess I could write something about it in the description. > > Yours, > Linus Walleij
