Re: [PATCH v2 1/4] dt-bindings: leds: bcm63138: Add shift register bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 28, 2024 at 12:29:47AM +0200, Linus Walleij wrote:
> The BCM63138 family of serial LED controllers has a register
> where we can set up bits for the shift registers. These are
> the number of rounds the bits need to be shifted before all
> bits have been shifted through the external shift registers.
> 
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v1->v2:
> - Drop the $ref to u32 since the new property is suffixed
>   with "-bits" and thus get standard treatment.
> ---
>  Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
> index bb20394fca5c..b3d530c46061 100644
> --- a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
> @@ -41,6 +41,17 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  brcm,serial-shift-bits:

bits is an uint32-array, so you need to limit number of items, e.g.
items:
 - minimum: 1
   maximum: 32

default: [0]? or something else?

> +    minimum: 1
> +    maximum: 32
> +    description:
> +      This describes the number of 8-bit serial shifters
> +      connected to the LED controller block. The hardware
> +      is typically using 8-bit shift registers with 8 LEDs
> +      per shift register, so 4 shifters results in 32 LEDs
> +      or 2 shifters give 16 LEDs etc, but the hardware
> +      supports any odd number of registers.

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux