On 19/09/2024 09:15, Ryan Chen wrote: >>>> >>>>> create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h >>>>> create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h >>>>> >>>>> diff --git a/include/dt-bindings/clock/aspeed,ast2700-clk.h >>>>> b/include/dt-bindings/clock/aspeed,ast2700-clk.h >>>>> new file mode 100644 >>>>> index 000000000000..63021af3caf5 >>>>> --- /dev/null >>>>> +++ b/include/dt-bindings/clock/aspeed,ast2700-clk.h >>>> >>>> Use compatible as filename. >>> Modify from aspeed,ast2700-clk.h to aspeed, clk-ast2700.h, is it ok? >>> How about the aspeed,ast2700-reset.h file name is ok ? >> >> No. For both use the same filename, so the full compatible. FULL. > > Do you mean remove aspeed,ast2700-reset.h? > And move reset information into "aspeed, clk-ast2700.h" >> I did not say that. "For both" means for both files, so you can keep both files. Best regards, Krzysztof