On 16/09/2024 11:10, Ryan Chen wrote: > Add reset, clock dt bindings for AST2700. > > Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx> > --- > .../dt-bindings/clock/aspeed,ast2700-clk.h | 163 ++++++++++++++++++ > .../dt-bindings/reset/aspeed,ast2700-reset.h | 124 +++++++++++++ > 2 files changed, 287 insertions(+) This is supposed to be part of the commit adding these bindings. You got this comment already, didn't you? > create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h > create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h > > diff --git a/include/dt-bindings/clock/aspeed,ast2700-clk.h b/include/dt-bindings/clock/aspeed,ast2700-clk.h > new file mode 100644 > index 000000000000..63021af3caf5 > --- /dev/null > +++ b/include/dt-bindings/clock/aspeed,ast2700-clk.h Use compatible as filename. Best regards, Krzysztof