> Subject: Re: [PATCH v3 2/4] dt-bindings: Add AST2700 bindings > > On 19/09/2024 08:01, Ryan Chen wrote: > >> Subject: Re: [PATCH v3 2/4] dt-bindings: Add AST2700 bindings > >> > >> On 16/09/2024 11:10, Ryan Chen wrote: > >>> Add reset, clock dt bindings for AST2700. > >>> > >>> Signed-off-by: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx> > >>> --- > >>> .../dt-bindings/clock/aspeed,ast2700-clk.h | 163 > >> ++++++++++++++++++ > >>> .../dt-bindings/reset/aspeed,ast2700-reset.h | 124 +++++++++++++ > >>> 2 files changed, 287 insertions(+) > >> > >> This is supposed to be part of the commit adding these bindings. You > >> got this comment already, didn't you? > > > > Sorry, I may mis-understood your point in previous. > > I think you are ask, yaml and dt-binding header to be the same patch, right? > > It is one patch adding the binding for the device and headers. Thanks. > > > > >> > >>> create mode 100644 include/dt-bindings/clock/aspeed,ast2700-clk.h > >>> create mode 100644 include/dt-bindings/reset/aspeed,ast2700-reset.h > >>> > >>> diff --git a/include/dt-bindings/clock/aspeed,ast2700-clk.h > >>> b/include/dt-bindings/clock/aspeed,ast2700-clk.h > >>> new file mode 100644 > >>> index 000000000000..63021af3caf5 > >>> --- /dev/null > >>> +++ b/include/dt-bindings/clock/aspeed,ast2700-clk.h > >> > >> Use compatible as filename. > > Modify from aspeed,ast2700-clk.h to aspeed, clk-ast2700.h, is it ok? > > How about the aspeed,ast2700-reset.h file name is ok ? > > No. For both use the same filename, so the full compatible. FULL. Do you mean remove aspeed,ast2700-reset.h? And move reset information into "aspeed, clk-ast2700.h" > > Best regards, > Krzysztof
