On Tue, Aug 13, 2024 at 9:45 PM Charles Wang <charles.goodix@xxxxxxxxx> wrote: > > The Goodix GT7986U touch controller report touch data according to the > HID protocol through the SPI bus. However, it is incompatible with > Microsoft's HID-over-SPI protocol. > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx> > --- > .../bindings/input/goodix,gt7986u.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > new file mode 100644 > index 000000000..a7d42a5d6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GOODIX GT7986U SPI HID Touchscreen > + > +maintainers: > + - Charles Wang <charles.goodix@xxxxxxxxx> > + > +description: Supports the Goodix GT7986U touchscreen. > + This touch controller reports data packaged according to the HID protocol, > + but is incompatible with Microsoft's HID-over-SPI protocol. > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + enum: > + - goodix,gt7986u This is already documented in goodix,gt7375p.yaml. Now linux-next has warnings: /builds/robherring/linux-dt/Documentation/devicetree/bindings/input/goodix,gt7986u.example.dtb: touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed: ['goodix,gt7986u'] is too short 'goodix,gt7375p' was expected from schema $id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/input/goodix,gt7986u.example.dtb: touchscreen@0: reg:0:0: 0 is not one of [93, 20] from schema $id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/input/goodix,gt7986u.example.dtb: touchscreen@0: 'vdd-supply' is a required property from schema $id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml# /builds/robherring/linux-dt/Documentation/devicetree/bindings/input/goodix,gt7986u.example.dtb: touchscreen@0: 'goodix,hid-report-addr', 'spi-max-frequency' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml# Please sort this out and send a fix. Rob
