On 8/27/2024 11:55 AM, Krzysztof Kozlowski wrote:
On Tue, Aug 27, 2024 at 10:27:54AM +0530, Sricharan R wrote:
From: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
Add Qualcomm PCIe UNIPHY 28LP driver support present
in Qualcomm IPQ5018 SoC and the phy init sequence.
Signed-off-by: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
...
+static int qcom_uniphy_pcie_probe(struct platform_device *pdev)
+{
+ struct qcom_uniphy_pcie *phy;
+ int ret;
+ struct phy *generic_phy;
+ struct phy_provider *phy_provider;
+ struct device *dev = &pdev->dev;
+ struct device_node *np = of_node_get(dev->of_node);
+
+ phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL);
+ if (!phy)
+ return -ENOMEM;
+
+ platform_set_drvdata(pdev, phy);
+ phy->dev = &pdev->dev;
+
+ phy->data = of_device_get_match_data(dev);
+ if (!phy->data)
+ return -EINVAL;
+
+ ret = qcom_uniphy_pcie_get_resources(pdev, phy);
+ if (ret < 0)
+ dev_err_probe(&pdev->dev, ret, "Failed to get resources:\n");
What the hell happened here? Read my review one more time and then git
grep for usage of dev_err_probe.
Ho ok, understood, missed it, will fix and resend.
Regards,
Sricharan
NAK.
Best regards,
Krzysztof
