RE: [PATCH v2 2/2] iio: imu: smi240: imu driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
>On 13/08/2024 11:41, Shen Jianping (ME-SE/EAD2) wrote:
>>> +EXPORT_SYMBOL_GPL(smi240_core_probe);
>>> +
>>> +MODULE_AUTHOR("Markus Lochmann <markus.lochmann@xxxxxxxxxxxx>");
>>> +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@xxxxxxxxxxxx>");
>>> +MODULE_DESCRIPTION("Bosch SMI240 driver"); MODULE_LICENSE("Dual
>>> +BSD/GPL");
>>
>> Hm? How many modules do you have here? What are their names?
>>
>> We have one module, named  "Bosch SMI240 driver". Any problem here?
>
>That's not the name of the module. That's description. What is the module filename
>(filename=name!)?
>
>Fix your quoting, because you misrepresent people's comments.

Sorry to give you this feeling, No, we we don't want to silence you to avoid work.  Just do not understand the module name correctly.

filename you mean the ko filename correct ?  We have only smi240.ko as output. Therefore just one module and we shall put MODULE_* only in one source file right. 
Shall we put in smi240_core.c or smi240_spi.c ?

Best regards,
Jianping Shen




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux