On 09/08/2024 13:16, Jianping.Shen@xxxxxxxxxxxx wrote: > + > +MODULE_AUTHOR("Markus Lochmann <markus.lochmann@xxxxxxxxxxxx>"); > +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@xxxxxxxxxxxx>"); > +MODULE_DESCRIPTION("Bosch SMI240 driver"); > +MODULE_LICENSE("Dual BSD/GPL"); Let's be clear here: if you bothered to look at your module, you would see that it is duplicated. I judged by code review and questioned it. This should lead you to double and triple check. But instead of double-checking, you engage in long discussion with reviewer. Sorry, that's wasting my time. Your job is to check it, if you got comments on this, not mine. Please carefully read upstreaming guides/presentations and which mistakes to avoid. Hint: wasting reviewer's time. NAK. Best regards, Krzysztof