* Eliad Peller <eliad@xxxxxxxxxx> [150311 06:39]: > On Wed, Mar 11, 2015 at 3:21 PM, Javier Martinez Canillas > <javier@xxxxxxxxxxxx> wrote: > > On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > >> On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: > >>> > >>> Right now it seems that all boards in mainline with a WiLink6 part are > >>> using internal clocks. So as a first step I think that adding an > >>> optional refclock-frequency and tcxoclock-frequency properties should > >>> be enough. > >>> > >>> It would be good if the driver supports getting the refclock and > >>> tcxoclock from an external provider in case a board gets these from > >>> external clocks but that can be done as a followup if there are boards > >>> in the future using that design. > >>> > >>> But please bear in mind that I'm not familiar with the clock handling > >>> in WiLink6 since the WiLink8 part used in the IGEP boards does not > >>> need these clocks and I only looked at Luciano's previous patches and > >>> the WiLink today driver today. So it would be good if Eliad can double > >>> check my assumptions to see if those are correct. > >> > sounds right. that's what i know as well. > > >> Sounds good. I'd also be fine with not implementing the case for > >> external clocks in the code until we need (and can test) it, but > >> I think it should be specified in the binding from the start. > >> > > Agreed. > > > great. so i'll implement the internal clocks case only. OK great sounds good to me also. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html