On Fri, Aug 09, 2024 at 07:36:35PM +0800, Jie Luo wrote: > > > On 8/8/2024 10:41 PM, Krzysztof Kozlowski wrote: > > On 08/08/2024 16:03, Luo Jie wrote: > > > The common PLL clock controller provides fixed rate output clocks to > > > the hardware blocks that enable ethernet function on IPQ platform. > > > > That's defconfig for all platforms, so how anyone can guess which one > > you target here? Be specific, which company, which Soc, which board > > needs it. > > > > Sure, I will update the commit message as below to provide the details > required. > > The common PLL hardware block is available in the Qualcomm IPQ SoC such > as IPQ9574 and IPQ5332. It provides fixed rate output clocks to Ethernet > related hardware blocks such as external Ethernet PHY or switch. This > driver is initially being enabled for IPQ9574. All boards based on > IPQ9574 SoC will require to include this driver in the build. Does it provide more than Ethernet clocks? I'm just wondering why the name `common`, when it seems pretty uncommon, specialised for Ethernet clocks on a couple of SoCs. Andrew
