Hi all, On Mon, Aug 05, 2024 at 09:00:20AM -0600, Rob Herring (Arm) wrote: > [snip] > > New warnings running 'make CHECK_DTBS=y sprd/sc9836-openphone.dtb sprd/sp9860g-1h10.dtb' for cover.1722842066.git.stano.jakubek@xxxxxxxxx: > > arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'battery-detect-gpios' is a required property > from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# This is a straigtforward fix, the sc2731.dtsi has ...-gpio instead of ...-gpios I can fix this in another patch, I'd like to get this series merged first. > arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'sprd,calib-resistance-micro-ohms' is a required property > from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# SPRD folks will have to chime in here as I do not have the board or any other source of information about it, so I cannot add this property. > arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: fuel-gauge@a00: 'bat-detect-gpio', 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/power/supply/sc27xx-fg.yaml# Looking at the driver, it seems to me that the interrupts are required, and thus should be added to the bindings. I can send a patch. Looking at the sc2731-fgu dtsi again, it seems like there's some further fixes/improvements that could be made (disable by default, move the monitored-battery to board DTS, etc.). Either way, this series should be good to go. Thanks, Stanislav
