On Tuesday, July 23, 2024 01:09 IST, hoff.benjamin.k@xxxxxxxxx wrote: Hi Benjamin, > > Add initial support for the Synopsys DesignWare HDMI RX > > Controller Driver used by Rockchip RK3588. The driver > > supports: > > - HDMI 1.4b and 2.0 modes (HDMI 4k@60Hz) > > - RGB888, YUV422, YUV444 and YCC420 pixel formats > > - CEC > > - EDID configuration > > > > The hardware also has Audio and HDCP capabilities, but these are > > not yet supported by the driver. > > > > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> > > Tested-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> > > Co-developed-by: Dingxian Wen <shawn.wen@xxxxxxxxxxxxxx> > > Signed-off-by: Dingxian Wen <shawn.wen@xxxxxxxxxxxxxx> > > Signed-off-by: Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> > > --- > > ... > > + > > +static const struct of_device_id hdmirx_id[] = { > > + { .compatible = "rockchip,rk3588-hdmirx-ctrler" }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(of, hdmirx_id); > > > > > According to the platform_driver struct, they like the `remove_new` over remove. > When I was compiling for Armbian, I was getting a type mismatch that prevented compililng > > See here: https://github.com/torvalds/linux/blob/933069701c1b507825b514317d4edd5d3fd9d417/include/linux/platform_device.h#L236 > This patch series is based on linux-next and there seems to be some recent changes related to .remove and .remove_new. New drivers are supposed to use .remove() See the reason here :- https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/include/linux/platform_device.h?h=next-20240722#n239 If you apply the patches on top of linux-next then there shouldn't be any compilation error. > > > > + > > +static struct platform_driver hdmirx_driver = { > > + .probe = hdmirx_probe, > > + .remove = hdmirx_remove, > > + .driver = { > > + .name = "snps_hdmirx", > > + .of_match_table = hdmirx_id, > > + .pm = &snps_hdmirx_pm_ops, > > + } > > +}; > > +module_platform_driver(hdmirx_driver); > > + > > +MODULE_DESCRIPTION("Rockchip HDMI Receiver Driver"); > > +MODULE_AUTHOR("Dingxian Wen <shawn.wen@xxxxxxxxxxxxxx>"); > > +MODULE_AUTHOR("Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx>"); > > +MODULE_LICENSE("GPL");