On 18/07/2024 09:04, Haylen Chu wrote: > On Wed, Jul 17, 2024 at 11:12:52AM +0200, Krzysztof Kozlowski wrote: >> On 17/07/2024 07:19, Haylen Chu wrote: >>> On Wed, Jul 17, 2024 at 08:05:10AM +0800, Chen Wang wrote: >>>> Haylen, so you want a compatible that matches an actual SoC and use it >>>> everywhere? >>>> >>>> Or we can add ones for each SoC and have a fallback to cv1800. >>> >>> I would prefer "sophgo,cv1800-thermal" and use it everywhere. I don't >>> see any difference on thermal sensors between cv18xx-series SoCs. >> >> Please use proper fallbacks - there is a very specific rule, repeated >> many times: >> >> https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 > > Just in case I misunderstood, > > You would prefer different SoC-specific compatible strings like > "sophgo,cv1800-thermal" "sophgo,sg2002-thermal" added to the driver, There is nothing in above - comment or guideline - mentioning drivers. > and each thermal-sensor node contains two compatible strings, one > matches the SoC exactly and one is "sophgo,cv1800-thermal" just as a > fallback, right? Best regards, Krzysztof
