On 16/07/2024 11:42, Haylen Chu wrote: > Add devicetree binding documentation for thermal sensors integrated in > Sophgo CV180X SoCs. > > Signed-off-by: Haylen Chu <heylenay@xxxxxxxxxxx> > --- > .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > new file mode 100644 > index 000000000000..58bd4432cd10 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sophgo CV1800 on-SoC Thermal Sensor > + > +maintainers: > + - Haylen Chu <heylenay@xxxxxxxxxxx> > + > +description: Sophgo CV1800 on-SoC thermal sensor > + Missing $ref to thermal-sensor.yaml > +properties: > + compatible: > + enum: > + - sophgo,cv1800-thermal > + > + reg: > + maxItems: 1 > + > + clocks: > + description: The thermal sensor clock Description is useless. You miss constraints on the other hand, so maxItems. > + > + interrupts: > + maxItems: 1 > + > + sample-rate-hz: > + minimum: 1 > + maximum: 1908 > + default: 1 > + > + '#thermal-sensor-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/sophgo,cv1800.h> > + #include <dt-bindings/interrupt-controller/irq.h> Use 4 spaces for example indentation. Best regards, Krzysztof