On 17/07/2024 07:19, Haylen Chu wrote: > On Wed, Jul 17, 2024 at 08:05:10AM +0800, Chen Wang wrote: >> Haylen, so you want a compatible that matches an actual SoC and use it >> everywhere? >> >> Or we can add ones for each SoC and have a fallback to cv1800. > > I would prefer "sophgo,cv1800-thermal" and use it everywhere. I don't > see any difference on thermal sensors between cv18xx-series SoCs. Please use proper fallbacks - there is a very specific rule, repeated many times: https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 Best regards, Krzysztof
