On 7/9/24 11:01 AM, Krzysztof Kozlowski wrote:
On 08/07/2024 23:01, Marek Vasut wrote:
+allOf:
+ - $ref: ethernet-phy.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ethernet-phy-id001c.c916
+ then:
+ properties:
+ leds: true
This has no effect. 'leds' node is already allowed with the ref to
ethernet-phy.yaml. I suppose you could negate the if and then, but I'm
not really that worried if someone defines LEDs for a device with no
LEDs.
So shall I simply do:
leds: true
and by done with it, as the easier way out ?
No, you should not have to do anything. Do you see any dtbs_check error
without this patch?
Not yet, but I do plan to describe PHY LEDs on a board I have locally,
with RTL8211F PHY.
I sent a V2 of this patch with leds:true and this conditional inverted.
