On Fri, Jul 05, 2024 at 11:51:46PM +0200, Marek Vasut wrote: > The RTL8211F PHY does support LED configuration, document support > for LEDs in the binding document. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > --- > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Andrew Lunn <andrew@xxxxxxx> > Cc: Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx> > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> > Cc: Heiner Kallweit <hkallweit1@xxxxxxxxx> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> > Cc: Paolo Abeni <pabeni@xxxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > --- > .../devicetree/bindings/net/realtek,rtl82xx.yaml | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml > index 18ee72f5c74a8..28c048368073b 100644 > --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml > +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml > @@ -14,9 +14,6 @@ maintainers: > description: > Bindings for Realtek RTL82xx PHYs > > -allOf: > - - $ref: ethernet-phy.yaml# > - > properties: > compatible: > enum: > @@ -54,6 +51,17 @@ properties: > > unevaluatedProperties: false > > +allOf: > + - $ref: ethernet-phy.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: ethernet-phy-id001c.c916 > + then: > + properties: > + leds: true This has no effect. 'leds' node is already allowed with the ref to ethernet-phy.yaml. I suppose you could negate the if and then, but I'm not really that worried if someone defines LEDs for a device with no LEDs. Rob
