Re: [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document RTL8211F LED support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/07/2024 23:01, Marek Vasut wrote:
>>>   
>>> +allOf:
>>> +  - $ref: ethernet-phy.yaml#
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: ethernet-phy-id001c.c916
>>> +    then:
>>> +      properties:
>>> +        leds: true
>>
>> This has no effect. 'leds' node is already allowed with the ref to
>> ethernet-phy.yaml. I suppose you could negate the if and then, but I'm
>> not really that worried if someone defines LEDs for a device with no
>> LEDs.
> 
> So shall I simply do:
> 
> leds: true
> 
> and by done with it, as the easier way out ?

No, you should not have to do anything. Do you see any dtbs_check error
without this patch?

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux