On 6/27/24 11:31, Uwe Kleine-König wrote:
Hello Alexandre,
On Thu, Jun 27, 2024 at 10:38:34AM +0200, Alexandre TORGUE wrote:
On 6/13/24 10:02, Uwe Kleine-König wrote:
To simplify identifying the pins where the PWM output is routed to,
add a comment to each PWM device about the respective pin on the
expansion connector.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
---
arch/arm/boot/dts/st/stm32mp135f-dk.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b/arch/arm/boot/dts/st/stm32mp135f-dk.dts
index 567e53ad285f..f1b50e4c1059 100644
--- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts
+++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts
@@ -273,6 +273,7 @@ &timers3 {
/delete-property/dma-names;
status = "disabled";
pwm {
+ /* PWM output on pin 7 of the expansion connector (CN8.7) using TIM3_CH4 function */
pinctrl-0 = <&pwm3_pins_a>;
pinctrl-1 = <&pwm3_sleep_pins_a>;
pinctrl-names = "default", "sleep";
@@ -288,6 +289,7 @@ &timers4 {
/delete-property/dma-names;
status = "disabled";
pwm {
+ /* PWM output on pin 31 of the expansion connector (CN8.31) using TIM4_CH2 function */
pinctrl-0 = <&pwm4_pins_a>;
pinctrl-1 = <&pwm4_sleep_pins_a>;
pinctrl-names = "default", "sleep";
@@ -303,6 +305,7 @@ &timers8 {
/delete-property/dma-names;
status = "disabled";
pwm {
+ /* PWM output on pin 32 of the expansion connector (CN8.32) using TIM8_CH3 function */
pinctrl-0 = <&pwm8_pins_a>;
pinctrl-1 = <&pwm8_sleep_pins_a>;
pinctrl-names = "default", "sleep";
@@ -316,6 +319,7 @@ timer@7 {
&timers14 {
status = "disabled";
pwm {
+ /* PWM output on pin 33 of the expansion connector (CN8.33) using TIM14_CH1 function */
pinctrl-0 = <&pwm14_pins_a>;
pinctrl-1 = <&pwm14_sleep_pins_a>;
pinctrl-names = "default", "sleep";
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
Good idea. Some lines exceed the 100 char. I could remove "function" or only
keep "func" instead. What do u think ?
I don't care much and would have expected that the line length isn't
that critical. Anyhow, shorten it to func if you prefer.
Not critical for sure. Just checkpatch that complain about it.
Note also that commit should be: "ARM: dts: stm32: ....". i can fix it by
myself.
Ack. I considered using
ARM: dts: stm32: stm32mp135f-dk: ...
but that felt like duplicating so I dropped the "stm32" part. Feel free
to add it.
Ok thanks
alex
Best regards
Uwe
