Re: [PATCH v5 5/5] drm/panel: jd9365da: Add the function of adjusting orientation

[Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>]

On 6/24/2024 7:19 AM, Zhaoxiong Lv wrote:
> This driver does not have the function to adjust the orientation,
> so this function is added.
>
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>

> ---
> Changes between V5 and V4:
> - 1. Change dev_err() to dev_err_probe().
>
> V4:https://lore.kernel.org/all/20240620080509.18504-5-lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
>
> Changes between V4 and V3:
> - No changes.
>
> ---
>   drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> index 593e12b31ebd..c6b669866fed 100644
> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> @@ -42,7 +42,7 @@ struct jadard {
>   	struct drm_panel panel;
>   	struct mipi_dsi_device *dsi;
>   	const struct jadard_panel_desc *desc;
> -
> +	enum drm_panel_orientation orientation;
>   	struct regulator *vdd;
>   	struct regulator *vccio;
>   	struct gpio_desc *reset;
> @@ -178,12 +178,20 @@ static int jadard_get_modes(struct drm_panel *panel,
>   	return 1;
>   }
>   
> +static enum drm_panel_orientation jadard_panel_get_orientation(struct drm_panel *panel)
> +{
> +	struct jadard *jadard = panel_to_jadard(panel);
> +
> +	return jadard->orientation;
> +}
> +
>   static const struct drm_panel_funcs jadard_funcs = {
>   	.disable = jadard_disable,
>   	.unprepare = jadard_unprepare,
>   	.prepare = jadard_prepare,
>   	.enable = jadard_enable,
>   	.get_modes = jadard_get_modes,
> +	.get_orientation = jadard_panel_get_orientation,
>   };
>   
>   static int radxa_display_8hd_ad002_init_cmds(struct jadard *jadard)
> @@ -880,6 +888,10 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
>   	drm_panel_init(&jadard->panel, dev, &jadard_funcs,
>   		       DRM_MODE_CONNECTOR_DSI);
>   
> +	ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation);
> +	if (ret < 0)
> +		return dev_err_probe(dev, ret, "failed to get orientation\n");
> +
>   	ret = drm_panel_of_backlight(&jadard->panel);
>   	if (ret)
>   		return ret;
> --
> 2.17.1