On Thu, 20 Jun 2024 23:29:56 +1200 Ryan Walklin <ryan@xxxxxxxxxxxxx> wrote: > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add display engine bus, clock and mixer bindings for the DE33. > > Signed-off-by: Ryan Walklin <ryan@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 7 ++++--- > .../bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml | 1 + > .../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 1 + > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > index 9845a187bdf65..631027375e33b 100644 > --- a/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > +++ b/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml > @@ -23,9 +23,10 @@ properties: > compatible: > oneOf: > - const: allwinner,sun50i-a64-de2 > - - items: > - - const: allwinner,sun50i-h6-de3 > - - const: allwinner,sun50i-a64-de2 > + - enum: > + - allwinner,sun50i-h6-de3 > + - allwinner,sun50i-h616-de33 > + - const: allwinner,sun50i-a64-de2 That doesn't look right, that would allow: - h6-de - h616-de33 - a64-de2 which is not what we want, right? It's more: - h6-de, a64-de2 - h616-de, a64-de2 - a64-de2 I think allwinner,sun8i-a23-rsb.yaml uses the pattern you are after. Cheers, Andre > > reg: > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > index 70369bd633e40..7fcd55d468d49 100644 > --- a/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml > @@ -25,6 +25,7 @@ properties: > - const: allwinner,sun50i-a64-de2-clk > - const: allwinner,sun50i-h5-de2-clk > - const: allwinner,sun50i-h6-de3-clk > + - const: allwinner,sun50i-h616-de33-clk > - items: > - const: allwinner,sun8i-r40-de2-clk > - const: allwinner,sun8i-h3-de2-clk > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index b75c1ec686ad2..c37eb8ae1b8ee 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -24,6 +24,7 @@ properties: > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > + - allwinner,sun50i-h616-de33-mixer-0 > > reg: > maxItems: 1
