On 2024-06-11 14:51, Rob Herring (Arm) wrote:
On Tue, 11 Jun 2024 13:40:15 +0200, Martin Schiller wrote:
Convert the lantiq,gswip bindings to YAML format.
Also add this new file to the MAINTAINERS file.
Signed-off-by: Martin Schiller <ms@xxxxxxxxxx>
---
.../bindings/net/dsa/lantiq,gswip.yaml | 195
++++++++++++++++++
.../bindings/net/dsa/lantiq-gswip.txt | 146 -------------
MAINTAINERS | 1 +
3 files changed, 196 insertions(+), 146 deletions(-)
create mode 100644
Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
delete mode 100644
Documentation/devicetree/bindings/net/dsa/lantiq-gswip.txt
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.example.dtb:
switch@e108000: ports:port@6: 'phy-mode' is a required property
from schema $id:
http://devicetree.org/schemas/net/dsa/lantiq,gswip.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.example.dtb:
switch@e108000: ports:port@6: 'oneOf' conditional failed, one must be
fixed:
'fixed-link' is a required property
'phy-handle' is a required property
'managed' is a required property
from schema $id:
http://devicetree.org/schemas/net/dsa/lantiq,gswip.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.example.dtb:
switch@e108000: Unevaluated properties are not allowed ('dsa,member',
'ports' were unexpected)
from schema $id:
http://devicetree.org/schemas/net/dsa/lantiq,gswip.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240611114027.3136405-2-ms@xxxxxxxxxx
The base for the series is generally the latest rc1. A different
dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself.
Note
that DT_SCHEMA_FILES can be set to your schema file to speed up
checking
your schema. However, it must be unset to test all examples with your
schema.
I have already run 'make dt_binding_check' and got no errors. However, I
then moved the components that are now being criticized to a separate
patch. These are exactly the properties that the original patch would
have added in the example.
I have currently put the conversion to the YAML schema in a separate
patch before adding these properties to preserve the original patch.
Should I combine both changes into one patch instead?
