Hi Andrew, On Mon, Mar 18, 2024 at 01:58:56PM +0100, Andrew Lunn wrote: > > I don't know if there are public errata about this issue. It is beyong > > my areas of expertise. I've found a relatively recent e-mail on the > > netdev mailing list that seems related ([1]), but there was no reply. > > > > [1] https://lore.kernel.org/netdev/9c1c9408-88ac-4ade-b8ec-2ae5d8922cac@xxxxxxxxxxxxxx/ > > Thanks for the link. > > Has anybody tried setting STMMAC_FLAG_RX_CLK_RUNS_IN_LPI. > > https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c#L816 > > The problem description makes it sound like the hardware does not like > the clock being turned off. Setting this flag might fix that. How would you recommend proceeding with this patch ? I can drop the eee-broken-1000t property as I didn't notice any issue, or keep with the risk that it my be cargo-cult. This is beyond my area of expertise, so I can perform tests if I get clear instructions, but I don't think I can investigate alone at this point. -- Regards, Laurent Pinchart
