On Sun, Mar 17, 2024 at 06:17:17PM +0100, Andrew Lunn wrote: > > +&eqos { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_eqos>; > > + phy-mode = "rgmii-id"; > > + phy-handle = <ðphy0>; > > + > > + mdio { > > + compatible = "snps,dwmac-mdio"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* Atheros AR8033 on v1.0, Realtek RTL8211E on v1.1 */ > > + ethphy0: ethernet-phy@0 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0>; > > + eee-broken-1000t; > > + }; > > Hi Laurent > > Do you happen to know what is broken with respect to EEE? It seems > like a lot of IMX boards have this, so i suspect it is the MAC. Maybe > we should be keying off the MAC compatible and disabling this in the > ethernet driver rather than have every .dts file needing it? I wonder if this could be cargo-cult. To be honest, I've copied it from the BSP and haven't investigated it. I've tried dropping that and haven't noticed any difference, but I'm not sure how I should test it properly. -- Regards, Laurent Pinchart