Hi Geert, Thank you for the review. On Wed, Jun 5, 2024 at 12:39 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Thu, May 30, 2024 at 7:41 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Fix the typo B0WI -> BOWI to match with the RZ/G2L HW manual. > > > > Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > v2->v3 > > - New patch > > Thanks for your patch! > > I had a deeper look, as the name "B0WI" (with zero) is also present > in drivers/pinctrl/renesas/pinctrl-rza2.c, and because Section 41.4.2 > ("Operation for Peripheral Function") in the RZ/G2L Group Hardware > User's Manual does talk about the "B0WI" (with zero) bit. > > Apparently Rev. 0.51 of the RZ/A2M Group Hardware User's Manual used > both variants. Later (Rev. 1.00) revisions replaced the O-based > variant by the zero-based variant. So it looks like "B0WI" (with > zero) is correct, and the RZ/G2L, RZ/V2L, RZ/G2UL, and RZ/Five HW > manuals should be fixed instead. The RZ/G3S manual already uses > the correct naming. > Ok I'll drop this patch and create a request with the HW manual team to correct it. Cheers, Prabhakar