Hi Witold, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Witold-Sadowski/spi-dt-bindings-cadence-Add-Marvell-overlay-bindings-documentation-for-Cadence-XSPI/20240530-060250 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next patch link: https://lore.kernel.org/r/20240529220026.1644986-5-wsadowski%40marvell.com patch subject: [PATCH v7 4/4] spi: cadence: Add MRVL overlay xfer operation support config: powerpc64-randconfig-r071-20240531 (https://download.01.org/0day-ci/archive/20240602/202406020007.yDo5EI4r-lkp@xxxxxxxxx/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project bafda89a0944d947fc4b3b5663185e07a397ac30) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202406020007.yDo5EI4r-lkp@xxxxxxxxx/ New smatch warnings: drivers/spi/spi-cadence-xspi.c:955 cdns_xspi_stig_ready() warn: signedness bug returning '(-110)' drivers/spi/spi-cadence-xspi.c:967 cdns_xspi_sdma_ready() warn: signedness bug returning '(-110)' vim +955 drivers/spi/spi-cadence-xspi.c 66e19aa5a2e022b Witold Sadowski 2024-05-29 951 static bool cdns_xspi_stig_ready(struct cdns_xspi_dev *cdns_xspi, bool sleep) 66e19aa5a2e022b Witold Sadowski 2024-05-29 952 { 66e19aa5a2e022b Witold Sadowski 2024-05-29 953 u32 ctrl_stat; 66e19aa5a2e022b Witold Sadowski 2024-05-29 954 66e19aa5a2e022b Witold Sadowski 2024-05-29 @955 return readl_relaxed_poll_timeout 66e19aa5a2e022b Witold Sadowski 2024-05-29 956 (cdns_xspi->iobase + CDNS_XSPI_CTRL_STATUS_REG, 66e19aa5a2e022b Witold Sadowski 2024-05-29 957 ctrl_stat, 66e19aa5a2e022b Witold Sadowski 2024-05-29 958 ((ctrl_stat & BIT(3)) == 0), 66e19aa5a2e022b Witold Sadowski 2024-05-29 959 sleep ? MRVL_XSPI_POLL_DELAY_US : 0, 66e19aa5a2e022b Witold Sadowski 2024-05-29 960 sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0); This works but from the name you would expect it to return true when it's ready and false when it's not. 66e19aa5a2e022b Witold Sadowski 2024-05-29 961 } 66e19aa5a2e022b Witold Sadowski 2024-05-29 962 66e19aa5a2e022b Witold Sadowski 2024-05-29 963 static bool cdns_xspi_sdma_ready(struct cdns_xspi_dev *cdns_xspi, bool sleep) 66e19aa5a2e022b Witold Sadowski 2024-05-29 964 { 66e19aa5a2e022b Witold Sadowski 2024-05-29 965 u32 ctrl_stat; 66e19aa5a2e022b Witold Sadowski 2024-05-29 966 66e19aa5a2e022b Witold Sadowski 2024-05-29 @967 return readl_relaxed_poll_timeout 66e19aa5a2e022b Witold Sadowski 2024-05-29 968 (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, 66e19aa5a2e022b Witold Sadowski 2024-05-29 969 ctrl_stat, 66e19aa5a2e022b Witold Sadowski 2024-05-29 970 (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), 66e19aa5a2e022b Witold Sadowski 2024-05-29 971 sleep ? MRVL_XSPI_POLL_DELAY_US : 0, 66e19aa5a2e022b Witold Sadowski 2024-05-29 972 sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0); 66e19aa5a2e022b Witold Sadowski 2024-05-29 973 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
