> -----Original Message----- > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Sent: Tuesday, June 4, 2024 11:22 AM > To: oe-kbuild@xxxxxxxxxxxxxxx; Witold Sadowski <wsadowski@xxxxxxxxxxx>; > linux-kernel@xxxxxxxxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx > Cc: lkp@xxxxxxxxx; oe-kbuild-all@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxx; > robh@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > pthombar@xxxxxxxxxxx; Witold Sadowski <wsadowski@xxxxxxxxxxx> > Subject: [EXTERNAL] Re: [PATCH v7 4/4] spi: cadence: Add MRVL overlay xfer > operation support > > Prioritize security for external emails: Confirm sender and content safety > before clicking links or opening attachments > > ---------------------------------------------------------------------- > Hi Witold, > > kernel test robot noticed the following build warnings: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__git- > 2Dscm.com_docs_git-2Dformat-2Dpatch-23-5Fbase-5Ftree- > 5Finformation&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=GKgcn-g6ZX- > JmCL3S2qKgVQhvhv7hu2n8En-dZbLTa8&m=3T1y56pUB9HOjzo3- > EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=07hYvagESNc9n4j7O0lrzZcF > lmVTYeR4d95yszqqbbA&e= ] > > url: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_intel-2Dlab-2Dlkp_linux_commits_Witold-2DSadowski_spi-2Ddt- > 2Dbindings-2Dcadence-2DAdd-2DMarvell-2Doverlay-2Dbindings-2Ddocumentation- > 2Dfor-2DCadence-2DXSPI_20240530- > 2D060250&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=GKgcn-g6ZX- > JmCL3S2qKgVQhvhv7hu2n8En-dZbLTa8&m=3T1y56pUB9HOjzo3- > EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=L5rHOjcT7_LtRsrf- > 8usYbyZ1nygU8VSbseBArBD4Gw&e= > base: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__git.kernel.org_pub_scm_linux_kernel_git_broonie_spi.git&d=DwIBAg&c=nKj > Wec2b6R0mOyPaz7xtfQ&r=GKgcn-g6ZX-JmCL3S2qKgVQhvhv7hu2n8En- > dZbLTa8&m=3T1y56pUB9HOjzo3- > EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=Z49n1j1P9sWiOEwpdOUyPisI > LleXaHHWL3gqPnZMnjY&e= for-next > patch link: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__lore.kernel.org_r_20240529220026.1644986-2D5-2Dwsadowski- > 2540marvell.com&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=GKgcn-g6ZX- > JmCL3S2qKgVQhvhv7hu2n8En-dZbLTa8&m=3T1y56pUB9HOjzo3- > EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=enzvWq1OJNu52elgRFFsdNYY > M66--SRJXq13KKmZycI&e= > patch subject: [PATCH v7 4/4] spi: cadence: Add MRVL overlay xfer > operation support > config: powerpc64-randconfig-r071-20240531 > (https://urldefense.proofpoint.com/v2/url?u=https- > 3A__download.01.org_0day-2Dci_archive_20240602_202406020007.yDo5EI4r- > 2Dlkp-40intel.com_config&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=GKgcn-g6ZX- > JmCL3S2qKgVQhvhv7hu2n8En-dZbLTa8&m=3T1y56pUB9HOjzo3- > EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=XlRP4onlzTi33VFScF3JKa8D > gPsSALAwrYapdtVzgy8&e= ) > compiler: clang version 19.0.0git > (https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_llvm_llvm- > 2Dproject&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=GKgcn-g6ZX- > JmCL3S2qKgVQhvhv7hu2n8En-dZbLTa8&m=3T1y56pUB9HOjzo3- > EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=ndehxuXJ9Np2ZrPiPcWAZV3K > CIWkfsgKavjDFYmr5s8&e= bafda89a0944d947fc4b3b5663185e07a397ac30) > > If you fix the issue in a separate patch/commit (i.e. not just a new > version of the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > | Closes: > | https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_r > | _202406020007.yDo5EI4r-2Dlkp-40intel.com_&d=DwIBAg&c=nKjWec2b6R0mOyPaz > | 7xtfQ&r=GKgcn-g6ZX-JmCL3S2qKgVQhvhv7hu2n8En-dZbLTa8&m=3T1y56pUB9HOjzo3 > | -EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=oMyRM-yKxK3MXd83MBK > | fR__LIwxmob86rs5qIz1iV6Q&e= > > New smatch warnings: > drivers/spi/spi-cadence-xspi.c:955 cdns_xspi_stig_ready() warn: signedness > bug returning '(-110)' > drivers/spi/spi-cadence-xspi.c:967 cdns_xspi_sdma_ready() warn: signedness > bug returning '(-110)' > > vim +955 drivers/spi/spi-cadence-xspi.c > > 66e19aa5a2e022b Witold Sadowski 2024-05-29 951 static bool > cdns_xspi_stig_ready(struct cdns_xspi_dev *cdns_xspi, bool sleep) > 66e19aa5a2e022b Witold Sadowski 2024-05-29 952 { > 66e19aa5a2e022b Witold Sadowski 2024-05-29 953 u32 ctrl_stat; > 66e19aa5a2e022b Witold Sadowski 2024-05-29 954 > 66e19aa5a2e022b Witold Sadowski 2024-05-29 @955 return > readl_relaxed_poll_timeout > 66e19aa5a2e022b Witold Sadowski 2024-05-29 956 (cdns_xspi- > >iobase + CDNS_XSPI_CTRL_STATUS_REG, > 66e19aa5a2e022b Witold Sadowski 2024-05-29 957 ctrl_stat, > 66e19aa5a2e022b Witold Sadowski 2024-05-29 958 ((ctrl_stat & > BIT(3)) == 0), > 66e19aa5a2e022b Witold Sadowski 2024-05-29 959 sleep ? > MRVL_XSPI_POLL_DELAY_US : 0, > 66e19aa5a2e022b Witold Sadowski 2024-05-29 960 sleep ? > MRVL_XSPI_POLL_TIMEOUT_US : 0); > > This works but from the name you would expect it to return true when it's > ready and false when it's not. > > 66e19aa5a2e022b Witold Sadowski 2024-05-29 961 } 66e19aa5a2e022b Witold > Sadowski 2024-05-29 962 66e19aa5a2e022b Witold Sadowski 2024-05-29 963 > static bool cdns_xspi_sdma_ready(struct cdns_xspi_dev *cdns_xspi, bool > sleep) 66e19aa5a2e022b Witold Sadowski 2024-05-29 964 { > 66e19aa5a2e022b Witold Sadowski 2024-05-29 965 u32 ctrl_stat; > 66e19aa5a2e022b Witold Sadowski 2024-05-29 966 > 66e19aa5a2e022b Witold Sadowski 2024-05-29 @967 return > readl_relaxed_poll_timeout > 66e19aa5a2e022b Witold Sadowski 2024-05-29 968 (cdns_xspi- > >iobase + CDNS_XSPI_INTR_STATUS_REG, > 66e19aa5a2e022b Witold Sadowski 2024-05-29 969 ctrl_stat, > 66e19aa5a2e022b Witold Sadowski 2024-05-29 970 (ctrl_stat & > CDNS_XSPI_SDMA_TRIGGER), > 66e19aa5a2e022b Witold Sadowski 2024-05-29 971 sleep ? > MRVL_XSPI_POLL_DELAY_US : 0, > 66e19aa5a2e022b Witold Sadowski 2024-05-29 972 sleep ? > MRVL_XSPI_POLL_TIMEOUT_US : 0); > 66e19aa5a2e022b Witold Sadowski 2024-05-29 973 } > Ok, I will rework that to return non-inverted value. > -- > 0-DAY CI Kernel Test Service > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_intel_lkp- > 2Dtests_wiki&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=GKgcn-g6ZX- > JmCL3S2qKgVQhvhv7hu2n8En-dZbLTa8&m=3T1y56pUB9HOjzo3- > EL5gF5YmRfjS2So3PliL081jziAvO4ArfnIo9RLWQtkHevL&s=7_g- > spW_lOA62MlydcNUrv_58Ua2UFcfpe6GmRUHskQ&e=
