Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/05/2024 08.40, Thorsten Leemhuis wrote:
[adding Paolo, who committed the culprit]

On 23.05.24 12:44, Linux regression tracking (Thorsten Leemhuis) wrote:
On 17.05.24 08:27, Frank Wunderlich wrote:
Am 17. Mai 2024 04:17:47 MESZ schrieb "Arınç ÜNAL" <arinc.unal@xxxxxxxxxx>:
On 16/05/2024 23:48, Frank Wunderlich wrote:
From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

After commit 868ff5f4944a
("net: dsa: mt7530-mdio: read PHY address of switch from device tree")
the mt7531 switch on Bananapi-R64 was not detected.

mt7530-mdio mdio-bus:00: reset timeout
mt7530-mdio mdio-bus:00: probe with driver mt7530-mdio failed with error -110

Fix this by adding phy address in devicetree.


Frank, am I right assuming the regression is still present in mainline?
As from here it looks like for two weeks now there was no progress at
all to fix this (or I missed it, which is quite possible).

Makes me wonder if the maintainers should revert the culprit or if the
arm64 dts folks should accept your fix despite Arınç ÜNAL's (who from a
quick look on lore hasn't posted anything for two weeks now) comment.

I'm not against the patch. I'm against the logic it entails on the patch
log. I had already submitted a patch series that would've prevented this
issue back in 14 March 2024 [1]. I've asked numerous times for the patch
series to be applied [2][3][4][5].

Eventually Daniel asked for some changes [6]. But I won't have time to do
that anytime soon and I think the patch series is good enough to be applied
as is.

[1] https://lore.kernel.org/all/20240314-for-mediatek-mt7531-phy-address-v1-0-52f58db01acd@xxxxxxxxxx/
[2] https://lore.kernel.org/all/ff196055-ecd8-4563-bc01-ff2533a07109@xxxxxxxxxx/
[3] https://lore.kernel.org/all/a60fc16d-4236-427c-b4a8-ec6fdf62d9f0@xxxxxxxxxx/
[4] https://lore.kernel.org/all/facb8204-c2b3-4084-a2e3-4fbf3a3fdc9d@xxxxxxxxxx/
[5] https://lore.kernel.org/all/44e366ea-964a-4515-9027-2a2edfe12512@xxxxxxxxxx/
[6] https://lore.kernel.org/all/ZixU287DdhvRyZBe@xxxxxxxxxxxxxx/

Arınç




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux